Feature/duplicate fragments

UCL / frrant

2 stars 0 forks source link

Feature/duplicate fragments #439

Closed acholyn closed 2 months ago

acholyn commented 4 months ago

closes #393

Have expanded the current duplication functionality to include tracking of duplicates (similarly to mentions) and alerting users when attempting to edit certain facets of an anonymous/fragment if there are duplicates.
This functionality is extended to when fragments and anonymous fragments are converted between
When duplicating an anonymous/fragment the new fragment is added to the duplicates field
There is a field for anonymous fragments to be used when a conversion has happened
they have a property called duplicates_list which combines duplicates from the property and the reverse relationships

tcouch commented 3 months ago

A couple of things still to do:

Duplicating a duplicate should make the new fragment a duplicate of both the original and the first duplicate.
Users should see a warning that a fragment has duplicates if they try to edit it. Maybe a banner at the top?

acholyn commented 3 months ago

would it work in that when duplicating, if the original has duplicates, add those items to the new instance's list of duplicates and it to theirs?

acholyn commented 2 months ago

conversion issue should be fixed now but initially the new fragment page didn't load and I had to reload for it to display, wondering if this was specific to my device

tcouch commented 2 months ago

I think the migration leaf node error we're seeing is because GH actions actually runs some kind of merged version of this branch and development together. Usually it's quite good at telling you there's a conflict, but in the case of migrations it's not clever enough to warn that development has a 0070 migration file and so does this branch.

TL;DR: Merge development into this branch and resolve the migration conflict by making this branch's migration file 0071.