UCL / hiv-modelling

1 stars 0 forks source link

Updating naming of prep start dates #253

Closed jennifersmith203 closed 1 year ago

jennifersmith203 commented 1 year ago

Hi everyone. This pull request started out as renaming the PrEP starting / switching / stopping variables but I ended up looking though the PrEP code in some detail and have edited some other bits that didn't look consistent. I've also been making sure that the DPV-VR code works in the same way as the oral and injectable PrEP code. Sorry it's so long! It would be good to go through it together as I have a few questions as well.

The new PrEP date variables are: prep_xxx_current_start_date: start date of current PrEP course, whether that is first ever PrEP, switching from a different PrEP option, or restarting following a break due to ineligibility or choice prep_xxx_first_start_date: first ever PrEP start date (previously dt_prep_xxx_s) prep_xxx_restart_date: date of PrEP restart following stopping or pausing PrEP for any reason (to count number of prep re-initiations) (previously dt_prep_xxx_rs) prep_xxx_restart_date_choice: date of PrEP restart following decision to stop PrEP prep_xxx_restart_date_eligible: date of PrEP restart following pause due to ineligibility (np=0) (previously dt_prep_xxx_c) prep_xxx_switch_date: date of switch to this PrEP method from another method prep_xxx_last_stop_date: date at which PrEP type was last used

jennifersmith203 commented 1 year ago

Hi everyone,

Thanks again for going through this pull request with me. I’ve looked through it again and made the various changes we discussed. I’ve also added in the extra couple of bits of code from Andrew and Loveleen – please could you have a quick check at lines 3039 (search “who3_event_tm1”) and 7132-7134 (search “LBM Jul23”)?

I’ve made a note that we still need to update the highest_prep_pref section with regards to the “> .”, which I’ll look at in a separate pull request (or I think Vale might have a working version of that).

I had a look at the documentation to find out the reasoning behind the prep_inj_tm1 condition for diagprim_prep_inj. I couldn’t find it out exactly but it did refer to delayed detection of antibodies / RNA when a person is on CAB-LA – could that be it?

Also I had a look through the cost_test variables for prep_inj (x 1.5) and it looks fine to me.

If everyone is happy then I will go ahead and merge.

Thanks, Jenny