search

UCL / pyCascadia

Implementation of GEBCO cookbook remove-restore and other cleaning of topography/bathymetry. Uses `pyGMT`.
Mozilla Public License 2.0
9 stars 0 forks source link

Feature/reimplement nearneighbour #65

Closed JamieJQuinn closed 3 years ago

JamieJQuinn commented 3 years ago

This PR reimplements the nearneighbour call using pyGMT's clib instead of a manual os call to gmt. This is intended to help with the performance impact of writing temporary files (see #60). Although GMT will still write to a temporary file, pyGMT uses virtual files to ensure we don't have to write the input to GMT, so some savings should come from that. Additionally, we don't have to handle temporary files ourselves.

JamieJQuinn commented 3 years ago

I'm so confused why only macos and ubuntu 3.6 are failing...

alessandrofelder commented 3 years ago

(Also at a later timepoint/if we have time, it might be cool to move this implementation into pygmt itself)

Devaraj-G commented 3 years ago

@Alessandro pygmt version is 0.3.1. Thanks for the heads-up. Proper to have it in the README.

JamieJQuinn commented 3 years ago

Perhaps could have been its own PR but I've added environment.yml which is the equiv of requirements.txt for conda. Should simplify both the install instructions (which have been updated) and the CI (which has been updated).

JamieJQuinn commented 3 years ago

Phew! That could have gone better... @alessandrofelder take a look and reapprove if you're happy.