search

UCL / research-computing-with-cpp

UCL-ARC *C++ for Research* course
https://github-pages.ucl.ac.uk/research-computing-with-cpp/
25 stars 18 forks source link

Week 1 notes #109

Closed krishnakumarg1984 closed 1 year ago

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mmcleod89 commented 1 year ago

A couple of minor changes listed in comments above. In general looks good though! Might be worth adding a line or two to the index page to say that if the are not using the container then they should install git (and cmake?) before class, since this is mentioned in the text but not in one of the mandatory reading pages so it might be missed.

krishnakumarg1984 commented 1 year ago

@mmcleod89 Thanks a lot for reviewing this. I have incorporated your feedback, and updated the text accordingly. Can you please approve if you are satisfied with the updates?

I don't quite understand why the CI is failing (which blocks merging). Can someone please look into it since we need to release these notes to students soon! @dpshelio Could you please take a quick look?

JamieJQuinn commented 1 year ago

@krishnakumarg1984 see my changes to config.yml. Just implement them in this PR and we'll get on with life.

krishnakumarg1984 commented 1 year ago

Let's ignore this PR. Unable to get CI to build this. Let's instead use #112