Codeblocks have no newlines in generated html

UCL / research-computing-with-cpp

UCL-ARC *C++ for Research* course

https://github-pages.ucl.ac.uk/research-computing-with-cpp/

26 stars 18 forks source link

Codeblocks have no newlines in generated html #59

Closed jeydobson closed 4 years ago

jeydobson commented 4 years ago

Newlines are missing from codeblocks when html is generated from markdown. For example looking at 01research/sec06UnitTesting.md the markdown looks fine: newline shown in markdown whereas the generated html is missing newlines: missing newlines in html I (@jeydobson) don't remember seeing this on the online version of the notes published prior to the switch from MPHY0022 to PHAS0100 in Jan 2020 so it seems to be a new problem.

dpshelio commented 4 years ago

I believe this is because it's part of a item list and a code block needs an empty line in between.

jeydobson commented 4 years ago

OK that would explain why the earlier examples worked. I'll push a change to test this but guess we won't know if it has worked until actually merging as I cannot replicate the problem on my laptop -- could be because I'm using Jekyll 4.0. and had to switch the markdown processor to kramdown (just on my local version) as redcarpet not supported

jeydobson commented 4 years ago

Ok @dpshelio pull request #58 has this change in so can you merge that to see if it fixes this when deployed

dpshelio commented 4 years ago

It may be due to the version... If we use circle-ci then we can preview the PRs. I'll create an issue for that. Maybe we should update Jekyll and the rest of plugins. That may require more work though...

jeydobson commented 4 years ago

Closing this merge request as the extral line fix