search

UCL / rsd-engineeringcourse

Course materials for Research Software Engineering course.
http://github-pages.ucl.ac.uk/rsd-engineeringcourse/
Other
108 stars 97 forks source link

Week1 #111

Closed dpshelio closed 5 years ago

dpshelio commented 5 years ago

Note that the last commit has TODOs!!

ageorgou commented 5 years ago

Looks good @dpshelio, and I think I've covered the FIXMEs. I will check the images along with other issues for these chapters in another PR.

ageorgou commented 5 years ago

While the build succeds, Travis has the following eror on the last step:

$ git push -f -u origin gh-pages
ERROR: We're doing an SSH key audit.
Reason: unverified automatically (private key found in a public repository)
Please visit https://github.com/settings/keys/17645879
to approve this key so we know it's safe.
Fingerprint: 40:2c:72:43:84:69:73:6d:a9:e0:f3:b4:aa:d6:b3:0d
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

Not sure whose key that is. This won't be an issue after #113, but maybe we should check it anyway...