search

UCL / rsd-engineeringcourse

Course materials for Research Software Engineering course.
http://github-pages.ucl.ac.uk/rsd-engineeringcourse/
Other
108 stars 97 forks source link

Updates for next session #141

Closed dpshelio closed 5 years ago

dpshelio commented 5 years ago

@mattgillucl - corrected all! In markdown if you do:

1. this is
1. a numbered
1. list

renders as:

  1. this is
  2. a numbered
  3. list
dpshelio commented 5 years ago

Did we agree that a different page order makes more sense (#100)? Maybe Libraries, Installing LIbraries, then as it is (Writing, Argparse, ...)

It makes sense as it's now to me... argparse goes before as you can create a command line without a library. Then we use that to create the library. Between libraries or installing libraries... I don't know, it seems ok in this way after I've seen it taught.

Writing Libraries / 025TextFiles.ipynb:

There is still a comment about .pyc files even though there are none in the listed path (#94)

I thought I had added it... somehow I didn't :disappointed:

The section about the path is now not listed as supplementary material (which is fine, just not sure that was the intention!) Also, this is now repeated in Installing Libraries

Yes, I remove it because I think it's needed.

ageorgou commented 5 years ago

I think the problem is not mainly with finding the renamed files (although I don't understand exactly why, as the names are not hardcoded).

If you look at the Travis build for the push (not the PR), it looks for the new names, and converts them fine. However, it fails when converting a later file (ch05construction/09patterns). No idea why! The version of nbconvert is the same as before, when it was working... And it's also not consistent, it worked for f2236de...

dpshelio commented 5 years ago

I know... I'm just :crossed_fingers: to see whether the branch builds to merge this.

dpshelio commented 5 years ago

Sold! :heavy_check_mark: for push

ageorgou commented 5 years ago

All's well that ends well! :man_shrugging: