search

UCL / rsd-engineeringcourse

Course materials for Research Software Engineering course.
http://github-pages.ucl.ac.uk/rsd-engineeringcourse/
Other
118 stars 101 forks source link

bugfix/greenmap #183

Closed nels closed 3 years ago

nels commented 4 years ago

Fix for #182

Replaced Yandex geocoder service with Geocode.farm Replaced Yandex static maps with Google static map image download (not Google Maps API)

Geocode Farm allows 250 requests per day per IP address without an API key I'm sure Google will block requests if hammered but the 010exemplar.ipynb Notebook executes without problem.

I can't guarantee that the latitude & longitude to Google Maps coordinates are 100% accurate as I simply lifted that from a Gist here

However, not sure if that really matters as the general idea of downloading a map image & extracting the green pixels seems to work OK.

dpshelio commented 4 years ago

Yeah, with google was working sometimes... but if run on campus I think it counted all the students as the same person. And Travis was failing if we had a couple of PR the same day. :crossed_fingers: with this one!! Thanks a lot @nels! You are a :man_singer: :star:

nels commented 4 years ago

I was wondering about the IP limiting with all students on campus but since it's remote everybody has their own IP :crossed_fingers: :smile:

ageorgou commented 4 years ago

Oh, I hadn't seen the first review when I did mine! Oh well, two "independent" ones.