search

UCLA-Creative-Labs / spot-the-song

MIT License
2 stars 0 forks source link

fix: Fix processing of Firestore collection.get() #17

Closed darren2hang closed 1 year ago

darren2hang commented 1 year ago

There was a bug in db.client and the Song.all() and Lobby.all() function It was using map to process the result of openCollection().get() Instead the correct way to use it is with forEach

This is a guide on getting all the documents from a Firestore collection https://firebase.google.com/docs/firestore/query-data/get-data#get_multiple_documents_from_a_collection

To test, just make sure Lobby.all() and Song.all() can run

mergify[bot] commented 1 year ago

Thanks for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).