search

UCLA-IRL / NAC-ABE

Attribute-based Access Control over Named Data Networking
GNU General Public License v3.0
14 stars 11 forks source link

consumer: bug fix and some other minor changes #20

Closed dulalsaurab closed 1 year ago

tylerliu commented 1 year ago

Would it be better to fix ParamFetcher::getAbeType() to be an inline function that returns a reference to m_abeType? The member var m_abeType should be private, also.

dulalsaurab commented 1 year ago

ParamFetcher::getAbeType() is a getter function if needed compiler should automatically make it inline? Also, it's a const function, if we try to return a reference, will get an error binding reference of type ‘ndn::nacabe::AbeType&’ {aka ‘std::__cxx11::basic_string<char>&’} to ‘const AbeType’ {aka ‘const std::__cxx11::basic_string<char>’} discards qualifiers.

m_abeType is already private.