Closed dulalsaurab closed 1 year ago
CI does not pass.
cuz unit tests haven't been updated according to the new naming convention.
I am testing the path with mGuard, need to wait until my testing is done to proceed further.
I am testing the path with mGuard, need to wait until my testing is done to proceed further.
Integration with mGuard passed. Up to you guys.
@tylerliu seems that we're having problems on macOS. I believe this PR doesn't touch any platform specific things. How we should proceed? Merging and solve the CI issue later?
Hmmm are you suggesting we should proceed to merge? Or waiting #25 finishes first (which is another long story).
CI does not pass.