BUGFIX Correct use of asyncio in main.py

UCLA-IRL / ndn-python-repo

An NDN Repo implementation in Python

Apache License 2.0

16 stars 13 forks source link

BUGFIX Correct use of asyncio in main.py #61

Closed phylib closed 3 years ago

phylib commented 3 years ago

As detected by @jefft0 in the following issue report, the NDN-Python-Repo incorrectly uses asyncio, so that repo.py->listen() is never executed.

phylib commented 3 years ago

sorry, makes sense... Should have looked at the entire code more carefully before pushing :see_no_evil:

But there are also some failed tests. I need to double check what happens there...

zjkmxy commented 3 years ago

got Future <Future pending> attached to a different loop This seems to be something wrong with the eventloop again. The asyncio module changed a lot from 3.6 to 3.10.

phylib commented 3 years ago

Looks good to me.

OK, I'd suggest we merge this PR and create an issue report for fixing the test suite. What do you think?

I already double-checked. The tests were already broken before my commit.