better simulated device hierarchy- common functions for a device type should be in base classes

UCLALabRAD / LaSER-Project

Effort to add functionality to the EGGS-Campbell repository to allow for the simulation of hardware in experiments conducted by the Campbell and Hudson labs.

0 stars 0 forks source link

better simulated device hierarchy- common functions for a device type should be in base classes #10

Closed lando224 closed 1 year ago

lando224 commented 1 year ago

Starting to wonder if serial and gpib devices should be separate classes. Most of their differences are now in the communication wrapper.

lando224 commented 1 year ago

Worked on this. Idea is functions would be in base class and then implementer can write command dict for a specific device using the functions we provide. Made SimulatedOscilloscope,SimulatedFunctionGenerator,and SimulatedPiezo base classes

lando224 commented 1 year ago

Lots of duplicate code in the instr_models file.

lando224 commented 1 year ago

Closing for capstone submission