UCLALibrary / library-website-nuxt

Other

8 stars 2 forks source link

fix: APPS-2722 fix section-wrapper vshow statement on staff listing page #817

Closed farosFreed closed 3 months ago

farosFreed commented 3 months ago

Connected to APPS-2722

Notes:

Small change to add a condition to the v-show statement

Checklist:

[X ] I added github label for semantic versioning
[ ] I double checked it looks like the designs
[ ] I completed any required mobile breakpoint styling
[ ] I completed any required hover state styling
[ X] I included a working spec file
[ ] I added notes above about how long it took to build this component
[ ] UX has reviewed this PR
[ ] I assigned this PR to someone to review

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-817--uclalibrary-test-nuxt3x.netlify.app