farosFreed commented 5 months ago

Notes:

Refactored slugs with filters to support new syntax, might've found some bugs

Context bugs maybe came from muddy requirements from outside teams who are conflating programs and departments https://uclalibrary.atlassian.net/browse/APPS-2159

To solve this I made the program page title a backup when department is not authored but 'show staff listing' boolean is true

Time Report:

This took me 8ish hours to debug and build this, I encountered some weird bugs and undocumented behavior

Checklist:

[X ] I added github label for semantic versioning
[X] I double checked it looks like the designs
[ ] I completed any required mobile breakpoint styling
[ ] I completed any required hover state styling
[X ] I included a working spec file
[X ] I added notes above about how long it took to build this component
[ ] UX has reviewed this PR
[ ] I assigned this PR to someone to review

github-actions[bot] commented 5 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually: 1. Visit https://github.com/UCLALibrary/library-website-nuxt/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

github-actions[bot] commented 5 months ago

🚀 Deployed on https://deploy-preview-834--uclalibrary-test-nuxt3x.netlify.app

axamei commented 4 months ago

This looks good to me!

UCLALibrary / library-website-nuxt

fix: APPS-2761 replace old link format #834

Percy Screenshots