search

UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

feat: display embedded iframes in MediaItem #226

Closed sourcefilter closed 1 year ago

sourcefilter commented 1 year ago

most of the work is a refactor to implement the sizing logic in the MediaItem component, rather than its subcomponents (this allowed iframes to be easily inserted)

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-226--ucla-library-storybook.netlify.app

sourcefilter commented 1 year ago

Corresponding gql fragment: https://github.com/UCLALibrary/library-website-nuxt/pull/525

sourcefilter commented 1 year ago

Closed, including in https://github.com/UCLALibrary/ucla-library-website-components/pull/231