UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.

Other

6 stars 1 forks source link

feat: adds max-height to responsive-video in BannerHeader and BannerF… #227

Closed dianneweinthal closed 1 year ago

dianneweinthal commented 1 year ago

Connected to UX-812

adds max-height to responsive-video in BannerHeader and BannerFeatured to standardize Banner displays for impact report

Checklist:

[x] I checked that it is working locally in the dev server
[x] I checked that it is working locally in the storybook
[x] I checked that it is working locally in the library-website-nuxt dev server
[ ] I added a screenshot of it working
[ ] UX has reviewed and approved this
[x] I assigned this PR to someone on the dev team to review
[x] I used a conventional commit message
[x] I assigned myself to this PR

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-227--ucla-library-storybook.netlify.app

pghorpade commented 1 year ago

:tada: This PR is included in version 1.65.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: