search

UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: don't use `?.` operator in MediaItem #235

Closed sourcefilter closed 1 year ago

sourcefilter commented 1 year ago

The javascript safe access operator ?. is newer syntax with limited support, possible requiring babel transpilation. Storybook could handle it, but it causes an error in our nuxt setup

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-235--ucla-library-storybook.netlify.app

pghorpade commented 1 year ago

:tada: This PR is included in version 2.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: