UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

feat: ModalLightbox component #243

Closed sourcefilter closed 1 year ago

sourcefilter commented 1 year ago

Connected to APPS-1590

Component Created: ModalLightbox.vue

Stories: ~/stories/ModalLightbox.stories.js

Spec: ~/stories/ModalLightbox.spec.js

Notes:

Tried to adapt something that could be used for both MediaGallery and Campus Map layouts, but that proved too difficult. This is the Map layout, and can be generalized to other cases. Main content is inserted in a slot, and presented in the middle 75% of each window axis.

Also fixes an error warning about loading SectionHeader in FlexibleBlocks

Checklist:

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-243--ucla-library-storybook.netlify.app

sourcefilter commented 1 year ago

Storybook: https://deploy-preview-243--ucla-library-storybook.netlify.app/?path=/story/modal-lightbox--default

(uses a blank

with white background as content)

pghorpade commented 1 year ago

:tada: This PR is included in version 2.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: