search

UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

fix: SimpleCard truncaton #329

Closed sourcefilter closed 1 year ago

sourcefilter commented 1 year ago

It looks like chrome was applying -webkit-line-clamp by shrinking the text box and inserting an ellepsis, but then letting the box grow again and reveal more lines of text when applying flex-grow.

This PR disables flex-grow and inserts an empty spacer div to keep the icon at the bottom of the card.

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-329--ucla-library-storybook.netlify.app

pghorpade commented 1 year ago

:tada: This PR is included in version 2.34.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: