UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

feat: Add SiteNotificationAlert, RichText, ButtonLink, and Smart Link components #395

Closed pghorpade closed 1 year ago

pghorpade commented 1 year ago

Instead of mixins, either make it into a composable if it is reactive or just use as utils

Connected to APPS-2413

Component Created: SiteNotificationAlert.vue Component Created: RichText.vue Component Created: ButtonLink.vue Component Created: SmartLink.vue

Stories: ~/stories/SiteNotificationAlert.stories.js Stories: ~/stories/RichText.stories.js Stories: ~/stories/ButtonLink.stories.js Stories: ~/stories/SmartLink.stories.js

Spec: ~/stories/SiteNotificationAlert.spec.js Spec: ~/stories/RichText.spec.js Spec: ~/stories/ButtonLink.spec.js Spec: ~/stories/SmartLink.spec.js

Notes:

I have made some composables which can be converted to util functions instead. vue-router is available to components from storybook environment by adding it to preview.js svgloader will automatically load svg components

Checklist:

image

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-395--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 1 year ago

:tada: This PR is included in version 2.39.0-alpha.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pghorpade commented 2 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: