search

UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

feat: Add section header and sectionwrapper compositon api support and use antfu #403

Closed pghorpade closed 12 months ago

pghorpade commented 1 year ago

Connected to APPS-2413

Changes: Adds the following components, and its stories and specs:

Also removed template slot as it was used by vue-glide, not longer using vue-glide package as it is not compatible with vue3 No need to use .native modifier anymore as it is deprecated in vue3 Replaced == with === Using script setup and typescript lang for NewLightbox , MediaItem, and BlockMediaWithText Added types for MediaItem and MediaGalleryItem data Replaced ::v-deep as it is deprecated in vue3 to :deep() in styles. Using antfu eslint package. npm run lint moved the script setup on the top of the file in sfc Component files. Using Volar and Eslint in vscode and no longer using prettier in vscode

github-actions[bot] commented 1 year ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 year ago

🚀 Deployed on https://deploy-preview-403--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 12 months ago

:tada: This PR is included in version 2.39.0-alpha.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pghorpade commented 2 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: