UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: APPS-2460 add header components #415

Closed pghorpade closed 8 months ago

pghorpade commented 8 months ago

Connected to APPS-2460

Component Created: src/lib-components/ExampleMeapNavMastHead.vue src/lib-components/HeaderMain.vue src/lib-components/HeaderMainResponsive.vue src/lib-components/HeaderSmart.vue src/lib-components/NavMenuItem.vue src/lib-components/NavMenuItemResponsive.vue src/lib-components/NavMenuItemScriptSetup.vue src/lib-components/NavPrimary.vue src/lib-components/NavSecondary.vue src/lib-components/SearchResult.vue

Stories: src/stories/ExampleMeapNavMastHead.stories.js src/stories/HeaderMainResponsive.stories.js src/stories/HeaderSmart.spec.js src/stories/HeaderSmart.stories.js src/stories/NavPrimary.stories.js src/stories/NavSecondary.stories.js

Spec: src/stories/HeaderMainResponsive.spec.js src/stories/NavPrimary.spec.js src/stories/NavSecondary.spec.js

Notes:

Could not convert src/lib-components/NavMenuItem.vue to CAPI and typescript, have the sample code in the repo which is not working src/lib-components/NavMenuItemScriptSetup.vue NavMenuItemResponsive needs some refactor, as the code is complex as manipulating the dome directly instead of using the refs

Checklist:

github-actions[bot] commented 8 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 8 months ago

🚀 Deployed on https://deploy-preview-415--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 8 months ago

:tada: This PR is included in version 2.39.0-alpha.15 :tada:

The release is available on:

Your semantic-release bot :package::rocket: