feat: APPS-2459 Add Multiple Components - Githubissues

UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.

Other

4 stars 1 forks source link

feat: APPS-2459 Add Multiple Components #416

Closed tinuola closed 7 months ago

tinuola commented 8 months ago

Connected to APPS-2459

Component Created:

MastheadPrimary.vue
MastheadSecondary.vue
SectionCardsWithIllustrations.vue
ResponsiveImage.vue
SectionDualMasonry.vue
SectionSpacesList.vue
SimpleCards.vue

Stories:

~/stories/MastheadPrimary.stories.js
~/stories/MastheadSecondary.stories.js
~/stories/SectionCardsWithIllustrations.stories.js
~/stories/ResponsiveImage.stories.js
~/stories/SectionDualMasonry.stories.js
~/stories/SectionSpacesList.stories.js
~/stories/SimpleCards.stories.js

Spec:

~/stories/MastheadPrimary.spec.js
~/stories/MastheadSecondary.spec.js
~/stories/SectionCardsWithIllustrations.spec.js
~/stories/ResponsiveImage.spec.js
~/stories/SectionDualMasonry.spec.js
~/stories/SectionSpacesList.spec.js
~/stories/SimpleCards.spec.js

Notes:

MastHeadPrimary.vue and MastHeadSecondary.stories.js are currently missing the SearchHome component per ticket criteria.

Checklist:

[x] I checked that it is working locally in the dev server
[x] I checked that it is working locally in the storybook
[ ] I checked that it is working locally in the library-website-nuxt dev server
[ ] I added a screenshot of it working
[ ] UX has reviewed and approved this
[x] I assigned this PR to someone on the dev team to review
[x] I used a conventional commit message
[x] I assigned myself to this PR

github-actions[bot] commented 8 months ago

🚀 Deployed on https://deploy-preview-416--ucla-library-storybook-vue3x.netlify.app

tinuola commented 8 months ago

@pghorpade Changes addressed. PR ready for a second look. Thanks.

pghorpade commented 7 months ago

:tada: This PR is included in version 2.39.0-alpha.16 :tada:

The release is available on:

Your semantic-release bot :package::rocket: