UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

feat: APPS-2467 BannerHeader component #423

Closed tinuola closed 9 months ago

tinuola commented 9 months ago

Connected to APPS-2467

Component Created: BannerHeader.vue

Stories: ~/stories/BannerHeader.stories.js

Spec: ~/stories/BannerHeader.spec.js

Notes:

Checklist:

github-actions[bot] commented 9 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 9 months ago

🚀 Deployed on https://deploy-preview-423--ucla-library-storybook-vue3x.netlify.app

tinuola commented 9 months ago

@axamei I pushed some minor fixes before I saw you had already approved the PR. Can you do another quick scan? Apologies for the double work.

pghorpade commented 9 months ago

:tada: This PR is included in version 2.39.0-alpha.21 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pghorpade commented 2 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: