UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

fix: update search when clearing search bar #435

Closed sourcefilter closed 5 months ago

sourcefilter commented 5 months ago

connected to APPS-2541

emits a "search-ready" event which triggers a route update, api call, &c in library-website-nuxt

The only way to test this is locally with npm run build && npm link and npm link ucla-library-website-components in the website repo. I can confirm that it fixed the issue.

github-actions[bot] commented 5 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 5 months ago

🚀 Deployed on https://deploy-preview-435--ucla-library-storybook.netlify.app

pghorpade commented 5 months ago

:tada: This PR is included in version 2.41.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: