jendiamond commented 4 months ago

Component Created: Flexible/PullQuote.vue

Stories: ~/stories/Flexible_PullQuote.stories.js

Spec: ~/stories/Flexible_PullQuote.spec.js

Notes: May have to add this v-deep page level because of the RichText styling..

:deep(.pull-quote) {
    padding: 24px var(--spacing-text-left);
    --spacing-text-left: 64px;
    --container-width: $container-m-text + px;
  }

Updates PullQuote.vue with <RichText> for the text

Checklist:

[x] I checked that it is working locally in the dev server
[x] I checked that it is working locally in the storybook
[x] I checked that it is working locally in the library-website-nuxt dev server
[x] I added a screenshot of it working
[ ] UX has reviewed and approved this
[ ] I assigned this PR to someone on the dev team to review
[x] I used a conventional commit message
[x] I assigned myself to this PR

github-actions[bot] commented 4 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

github-actions[bot] commented 4 months ago

🚀 Deployed on https://deploy-preview-457--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 4 months ago

:tada: This PR is included in version 2.39.0-alpha.42 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

UCLALibrary / ucla-library-website-components

feat: APPS:2562 convert flexible-pull-quote component to vue3 #457

Percy Screenshots