UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: APPS-2552 flexible blocks component #467

Closed pghorpade closed 3 months ago

pghorpade commented 3 months ago

Connected to APPS-2552

Component Created: FlexibleBlocks.vue

Stories: ~/stories/FlexibleBlocks.stories.js

Spec: ~/stories/FlexibleBlocksspec.js

Notes:

Not all flexible blocks are migrated, so some code is commented on in this component. Also tried to add a generics feature of typescript, but was not completely happy with the implementation, as it was becoming more complicated with type guards, so made that into a separate PR, if we would like to use typescript in this component in the future. https://github.com/UCLALibrary/ucla-library-website-components/pull/466

Checklist:

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-467--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 3 months ago

:tada: This PR is included in version 2.39.0-alpha.45 :tada:

The release is available on:

Your semantic-release bot :package::rocket: