UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

feat: APPS-2561 convert flexible-media-with-text component to vue3 #469

Closed jendiamond closed 6 months ago

jendiamond commented 6 months ago

Connected to APPS-2561

https://deploy-preview-469--ucla-library-storybook-vue3x.netlify.app/?path=/docs/flexible-media-with-text--docs

NOTES on SmartLink being commented out below in Notes.

ALSO

Component Created: Flexible/MediaWithText.vue

Stories: ~/stories/Flexible_MediaWithText.stories.js

Spec: ~/stories/Flexible_MediaWithText.spec.js

Notes: Using data from https://test-craft.library.ucla.edu/admin/entries/helpTopic/2363-printing

BlockMediaWithTextFragment Query:

fragment BlockMediaWithTextFragment on ElementInterface {
    dataId : id
    typeHandle
    sectionTitle: titleGeneral
    sectionSummary: summary
    mediaWithText {
        ... on mediaWithText_mediaEmbed_BlockType {
            titleLink: titleEmbed
            description
            coverImage {
                ...MediaAsset
            }
            buttonText
            buttonUrl
            embedCode
            typeMedia
        }
        ... on mediaWithText_mediaUpload_BlockType {
            titleUpload
            description
            buttonText
            buttonUrl
            coverImage {
                ...MediaAsset
            }
            item: upload {
                ...MediaAsset
            }
            typeMedia
        }
    }
}

STILL IN QUESTION:

Line 103 in BlockMediaWithText:
<smart-link is still commented out. the <smart-link> makes the mobile styles NOT work. Undetermined as to why this is the case.

CONCLUSION: I think that the linkToMedia is a PDF ???

BlockMediWithText.js (mockData) coverImage: linkToMedia: 'https://uclalibrary.github.io/research-tips/assets/handouts/citation-integration-final.pdf',

We may want to style these differently in the future and to give them a section wrapper.

Checklist:

Screenshot 2024-03-12 at 5 29 58 PM
github-actions[bot] commented 6 months ago

🚀 Deployed on https://deploy-preview-469--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 6 months ago

:tada: This PR is included in version 2.39.0-alpha.48 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pghorpade commented 2 months ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: