Closed jendiamond closed 6 months ago
:tada: This PR is included in version 2.39.0-alpha.48 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Connected to APPS-2561
https://deploy-preview-469--ucla-library-storybook-vue3x.netlify.app/?path=/docs/flexible-media-with-text--docs
NOTES on SmartLink being commented out below in Notes.
ALSO
src/stories/mock/Flexible_MediaWithText.js
with real data structure from test-craftexport { default as FlexibleMediaGallery } from './Flexible/MediaGallery.vue'
in filesrc/lib-components/index.js
interface FlexibleSimpleCard extends ContentLink
in filesrc/types/flexible_types.ts
Component Created:
Flexible/MediaWithText.vue
Stories:
~/stories/Flexible_MediaWithText.stories.js
Spec:
~/stories/Flexible_MediaWithText.spec.js
Notes: Using data from https://test-craft.library.ucla.edu/admin/entries/helpTopic/2363-printing
BlockMediaWithTextFragment Query:
STILL IN QUESTION:
Line 103 in BlockMediaWithText:
<smart-link
is still commented out. the<smart-link>
makes the mobile styles NOT work. Undetermined as to why this is the case.v-if="mediaLink
and it still breaks the styles.SectionWrapper.stories.js
mediaLink: mockMediaWithText.mediaWithText[0].linkToMedia,
pages/about/components.vue
linkToMedia is Line 166: underconst flexibleMediaWithText
.mediaLink: mockMediaWithText.mediaWithText[0].linkToMedia,
CONCLUSION: I think that the linkToMedia is a PDF ???
BlockMediWithText.js
(mockData) coverImage: linkToMedia: 'https://uclalibrary.github.io/research-tips/assets/handouts/citation-integration-final.pdf',We may want to style these differently in the future and to give them a section wrapper.
Checklist: