UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: Add BaseRadioGroup and BaseCheckboxGroup components to vue3 and stories are new #475

Closed pghorpade closed 3 months ago

pghorpade commented 3 months ago

Connected to APPS-2617

Component Created: BaseRadioGroup.vue

Stories: ~/stories/BaseRadioGroup.stories.js

Spec: ~/stories/BaseRadioGroup.spec.js

Component Created: BaseCheckboxGroup.vue

Stories: ~/stories/BaseCheckboxGroup.stories.js

Spec: ~/stories/BaseCheckboxGroup.spec.js

Notes:

commented the watcher code as it may not be needed, will know once I work on search-generic filter buttons

Checklist:

https://deploy-preview-475--ucla-library-storybook-vue3x.netlify.app/?path=/story/search-dropdown-basecheckboxgroup--with-selection

https://deploy-preview-475--ucla-library-storybook-vue3x.netlify.app/?path=/story/search-dropdown-baseradiogroup--default

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-475--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 3 months ago

:tada: This PR is included in version 2.39.0-alpha.50 :tada:

The release is available on:

Your semantic-release bot :package::rocket: