UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: APPS-2565, APPS-2566 convert ImpactRichText & StoryWithImage to vue 3 #480

Closed farosFreed closed 3 months ago

farosFreed commented 3 months ago

Connected to APPS-2565, APPS-2566

Component Created: ImpactRichText.vue, StoryWithImage.vue

Stories: ~/stories/ImpactRichText.stories.js, ~/stories/StoryWithImage.stories.js

Spec: ~/stories/ImpactRichText.spec.js, ~/stories/StoryWithImage.spec.js

Notes:

Converting https://github.com/UCLALibrary/ucla-library-website-components/blob/6fa09ba3a750e4ced038d14fa4c25b5055fbde88/src/lib-components/StoryWithImage.vue

The original component had a computed value parsedRatio which referenced this.ratio ... however, it had no this.ratio prop. I tested the component without it and it seemed to function the same as the original version.

After discussing with the team, we decided to hardcode the value to 60


Also converted https://github.com/UCLALibrary/ucla-library-website-components/blob/6fa09ba3a750e4ced038d14fa4c25b5055fbde88/src/lib-components/ImpactRichText.vue ... which had the same variable setup, and I used the same solution.

Checklist:

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-480--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 3 months ago

:tada: This PR is included in version 2.39.0-alpha.55 :tada:

The release is available on:

Your semantic-release bot :package::rocket: