Closed farosFreed closed 3 months ago
In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
:tada: This PR is included in version 2.39.0-alpha.55 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Connected to APPS-2565, APPS-2566
Component Created: ImpactRichText.vue, StoryWithImage.vue
Stories: ~/stories/ImpactRichText.stories.js, ~/stories/StoryWithImage.stories.js
Spec: ~/stories/ImpactRichText.spec.js, ~/stories/StoryWithImage.spec.js
Notes:
Converting https://github.com/UCLALibrary/ucla-library-website-components/blob/6fa09ba3a750e4ced038d14fa4c25b5055fbde88/src/lib-components/StoryWithImage.vue
The original component had a computed value parsedRatio which referenced this.ratio ... however, it had no this.ratio prop. I tested the component without it and it seemed to function the same as the original version.
After discussing with the team, we decided to hardcode the value to 60
Also converted https://github.com/UCLALibrary/ucla-library-website-components/blob/6fa09ba3a750e4ced038d14fa4c25b5055fbde88/src/lib-components/ImpactRichText.vue ... which had the same variable setup, and I used the same solution.
Checklist: