feat: APPS-2633 | APPS-2634 | APPS-2635 | APPS-2636 | APPS-2581 | APPS-2582 | APPS-2583 Convert BlockStaffList, BlockStaffArticle, SectionStaffList, SectionStaffSubjectLibrarian, BlockStaffDetail to vue3 & Fix BlockStaffSubjectLibrarian

jendiamond commented 3 months ago

Component Created:

BlockStaffList.vue
BlockStaffArticle.vue
SectionStaffList.vue
SectionStaffArticleList.vue
SectionStaffSubjectLibrarian.vue
BlockStaffDetail.vue

Component Fixed:

BlockStaffSubjectLibrarian.vue

Stories:

/stories/BlockStaffList.stories.js
~/stories/BlockStaffArticle.stories.js
~/stories/SectionStaffList.stories.js
~/stories/SectionStaffArticleList.stories.js
~/stories/SectionStaffSubjectLibrarian.stories.js
~/stories/BlockStaffDetail.stories.js

Spec:

/stories/BlockStaffList.spec.js
~/stories/BlockStaffArticle.spec.js
~/stories/SectionStaffList.spec.js
~/stories/SectionStaffArticleList.spec.js
~/stories/SectionStaffSubjectLibrarian.spec.js
~/stories/BlockStaffDetail.spec.js

Notes:

This PR includes code in Flexible/BannerFeatured.vue because the
Run CI Suite / vite (pull_request) was failing with this error:

src/lib-components/Flexible/BannerFeatured.vue(83,20): 
error TS2345: 
Argument of type '{ title: string; to: string; }'
is not assignable to parameter of type 'LocationItemType'.

Type '{ title: string; to: string; }' is missing the following properties from type 'LocationItemType': id, image, locationType, uri, and 7 more.
 ELIFECYCLE  Command failed with exit code 2.

I commented out the code:

  // Currently BlockCardWithImageFragment.gql comments out
  // line 96. # location {id,title}
  // if (block.content && block.content[0].location)
  // locations.push(block.content[0].location)

because as noted in the code BlockCardWithImageFragment.gql comments out line 96. # location {id,title} in the library-website-nuxt site

        ... on cardWithImage_externalContent_BlockType {
            id
            typeHandle
            title: titleGeneral
            image {
                ...Image
            }
            byline1
            byline2
            category
            # location {
            #     id
            #     title
            # }
            text: summary
            to: externalLink
        }

Checklist: