UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: APPS-2569 convert SectionGenericList to vue3 #487

Closed farosFreed closed 2 months ago

farosFreed commented 2 months ago

Connected to APPS-2569

Component Created: SectionGenericList.vue

Stories: ~/stories/SectionGenericList.stories.js

Spec: ~/stories/SectionGenericList.spec.js

Notes:

When hooking this up to its child component I noticed some differences in prop names and data handling between parent and child component, I've done my best to document these differences on the SectionGenericListItemType in types.ts

Checklist:

github-actions[bot] commented 2 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 2 months ago

🚀 Deployed on https://deploy-preview-487--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 2 months ago

:tada: This PR is included in version 2.39.0-alpha.61 :tada:

The release is available on:

Your semantic-release bot :package::rocket: