UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: Apps-2559 convert HeaderSticky to vue3 #493

Closed farosFreed closed 2 months ago

farosFreed commented 2 months ago

Connected to APPS-2559

Component Created: HeaderSticky.vue

Stories: ~/stories/HeaderSticky.stories.js

Spec: ~/stories/HeaderSticky.spec.js

Notes:

🍵 I don't entirely understand why the story for this component needs to parse the secondary data, but the component itself does not. For now I've kept it the same because this is how the component and story are implemented in Vue 2.

I looked in the Nuxt library to try to understand, and I see the menu is powered by this HeaderMainMenuItems graphQL query, but I don't know exactly what this returns on live.

Checklist:

github-actions[bot] commented 2 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 2 months ago

🚀 Deployed on https://deploy-preview-493--ucla-library-storybook-vue3x.netlify.app

farosFreed commented 2 months ago
Screenshot 2024-04-09 at 8 49 07 AM
pghorpade commented 2 months ago

:tada: This PR is included in version 2.39.0-alpha.66 :tada:

The release is available on:

Your semantic-release bot :package::rocket: