UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

feat: APPS-2583-2582 Fix block StaffSubjectLibrarian & Convert SectionStaffSubjectLibrarian to vue3 #494

Closed jendiamond closed 2 months ago

jendiamond commented 2 months ago

Connected to 2583 & 2582

https://deploy-preview-494--ucla-library-storybook-vue3x.netlify.app/?path=/docs/configure-your-project--docs

Component Created:.

Stories:.

Spec: ~/stories/{filename}.spec.js

Notes:

  1. Refactored StaffName in the component so it does not have to be done on the page now.
  2. Fixed BlockStaffSubjectLibrarian.vue & BlockStaffSubjectLibrarian.stories.js because multiple fields were misising.
    • Job Title
    • Department
    • Locations

Before

Screenshot 2024-04-08 at 3 51 41 PM

Now

Screenshot 2024-04-08 at 3 52 32 PM

Checklist:

github-actions[bot] commented 2 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 2 months ago

🚀 Deployed on https://deploy-preview-494--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 2 months ago

:tada: This PR is included in version 2.39.0-alpha.68 :tada:

The release is available on:

Your semantic-release bot :package::rocket: