UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.

Other

4 stars 1 forks source link

chore: Apps-2640 update BlockGenericList.vue with same fix as vue 2 version #495

Closed farosFreed closed 2 months ago

farosFreed commented 2 months ago

Connected to APPS-2640

Notes:

Copying over the change from this PR

I added a story to cover the edge case which led to the discovery of this bug

Checklist:

[X] I checked that it is working locally in the dev server
[X] I checked that it is working locally in the storybook
[X] I checked that it is working locally in the library-website-nuxt dev server
[X] I added a screenshot of it working
[ ] UX has reviewed and approved this
[ ] I assigned this PR to someone on the dev team to review
[X] I used a conventional commit message
[X] I assigned myself to this PR

github-actions[bot] commented 2 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

farosFreed commented 2 months ago

new story

github-actions[bot] commented 2 months ago

🚀 Deployed on https://deploy-preview-495--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 2 months ago

:tada: This PR is included in version 2.39.0-alpha.69 :tada:

The release is available on:

Your semantic-release bot :package::rocket: