UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

fix: APPS-2668 SearchHome.vue query param should be q #507

Closed farosFreed closed 1 month ago

farosFreed commented 1 month ago

Connected to APPS-2668

Component Edited: SearchHome.vue

Spec Edited: ~/stories/SearchHome.spec.js, added a story for this requirement

Notes:

Sneaky error where we were passing the entire ref object for queryParam, instead of just the queryParam.value as a simple string

Checklist:

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-507--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 2.39.0-alpha.77 :tada:

The release is available on:

Your semantic-release bot :package::rocket: