UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.

Other

4 stars 1 forks source link

fix: APPS-2665 When user clicks the x on search keyword, the search is not triggered automatically #509

Closed farosFreed closed 1 month ago

farosFreed commented 1 month ago

Connected to APPS-2665

Notes:

Needed to add additional syntax to get the child component to emit the 'clear' event to its parent

Checklist:

[X ] I checked that it is working locally in the dev server
[ X] I checked that it is working locally in the storybook
[ ] I checked that it is working locally in the library-website-nuxt dev server
[ ] I added a screenshot of it working
[ ] UX has reviewed and approved this
[ ] I assigned this PR to someone on the dev team to review
[X ] I used a conventional commit message
[X ] I assigned myself to this PR

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-509--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 2.39.0-alpha.79 :tada:

The release is available on:

Your semantic-release bot :package::rocket: