UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

chore: APPS-2557 carryover improvements from nuxt2 branch #511

Closed farosFreed closed 1 month ago

farosFreed commented 1 month ago

Connected to APPS-2557

Stories Edited: ~/stories/CardMeta.stories.js

Notes:

I verified that these 2 changes were present in the branch:

Change 1: Highlight Text prop should be displayed using RichText component that can handle <a> tags, test data should test for <a>tags fix: APPS-2493 Hyperlink styling needed in FPB Highlight summary field by jendiamond · Pull Request #443 · UCLALibrary/ucla-library-website-components

Solution: As BlockHighlight.vue no longer exists, we needed to check that the components it was split into (BlockCardWithImage, BlockFloatingHighlight, BlockClippedDate) all had this behavior.

Luckily, all 3 components use CardMeta to display the text prop, so I needed to check that it was using the RichText component. It was already using RichText, so I added <a> tags to the test data.

Change 2: Update search results on input clear fix: update search when clearing search bar by sourcefilter · Pull Request #435 · UCLALibrary/ucla-library-website-components

Solution: No work needed, I had already made this fix as part of https://uclalibrary.atlassian.net/browse/APPS-2665

Checklist:

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-511--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 2.39.0-alpha.81 :tada:

The release is available on:

Your semantic-release bot :package::rocket: