UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
4 stars 1 forks source link

fix: APPS-2671 BannerFeatured digital eyebrow / category is not appearing #513

Closed jendiamond closed 1 month ago

jendiamond commented 1 month ago

Connected to

https://deploy-preview-513--ucla-library-storybook-vue3x.netlify.app/?path=/docs/flexible-banner-featured--docs

src/lib-components/Flexible/BannerFeatured.vue(92,62): error TS2339: Property 'workshopOrEventSeriesType' does not exist on type 'FlexibleBannerContentLink'.
src/lib-components/Flexible/BannerFeatured.vue(93,62): error TS2339: Property 'physicalDigital' does not exist on type 'FlexibleBannerContentLink'.
 ELIFECYCLE  Command failed with exit code 2.
github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-513--ucla-library-storybook-vue3x.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 2.39.0-alpha.81 :tada:

The release is available on:

Your semantic-release bot :package::rocket: