UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: APPS-2876 Component BlockEventDetail - No map icon If no location #583

Closed jendiamond closed 3 months ago

jendiamond commented 3 months ago

Connected to APPS-2876

Previously:

Screenshot 2024-08-06 at 9 50 16 PM

Locally in the Storybook with a new test

Screenshot 2024-08-06 at 10 06 44 PM

ok


Locally on the dev server

Screenshot 2024-08-06 at 9 59 04 PM

Locally on the ftva-website-nuxt dev server

Screenshot 2024-08-06 at 10 05 56 PM

Checklist:

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-583--ucla-library-storybook.netlify.app

pghorpade commented 3 months ago

:tada: This issue has been resolved in version 3.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: