UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

chore: refactor theme pattern to rescope styles, add deep() where needed #588

Closed farosFreed closed 3 months ago

farosFreed commented 3 months ago

Connected to APPS-2867

Notes:

When we implemented the theme pattern we introduced an anti-pattern that removed scoping (plus we are reloading the theme a lot which bloats the project). This has led to problems with styling, especially for the card-meta component which is reused as a child component in 4 other components (BlockCardWithImage, BlockClippedDate, BlockFloatingHighlight, SectionTeaserCard), in addition to being used directly on the page.

This PR:

Checklist:

github-actions[bot] commented 3 months ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 3 months ago

🚀 Deployed on https://deploy-preview-588--ucla-library-storybook.netlify.app

pghorpade commented 3 months ago

:tada: This issue has been resolved in version 3.8.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: