UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: APPS-3004 Fix Location links in component BlockEventDetail #635

Closed jendiamond closed 1 month ago

jendiamond commented 1 month ago

Connected to APPS-3004

https://deploy-preview-635--ucla-library-storybook.netlify.app/?path=/story/block-event-detail--default

Notes:

  1. src/lib-components/BlockEventDetail.vue
    • Add publicUrl?: string to the list of potential
    • Add a new line between the span tags
    • Fixes the Links: Changed from :to="location.title" to :to="locations[0].publicUrl" or :to="locations[0].url"
    • Adds 'parsedTarget` to have the link go to another page if external
  2. src/stories/BlockEventDetail.stories.js
    • Updates the stories for default and FTVA

Checklist:


ONE LOCATION:

Screenshot 2024-10-16 at 12 11 27 PM


NO LOCATION:

Screenshot 2024-10-16 at 12 12 11 PM


MULTIPLE LOCATIONS:

Screenshot 2024-10-16 at 12 10 26 PM

github-actions[bot] commented 1 month ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 1 month ago

🚀 Deployed on https://deploy-preview-635--ucla-library-storybook.netlify.app

pghorpade commented 1 month ago

:tada: This PR is included in version 3.29.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: