Closed farosFreed closed 9 hours ago
In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:
Screenshot of the drawer. The Calendar button styles will be tweaked a bit to match UX specs
:tada: This PR is included in version 3.36.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Connected to APPS-3045
Component Created: MobileDrawer.vue
Stories: ~/stories/MobileDrawer.stories.js
Spec: ~/stories/MobileDrawer.spec.js
Notes:
Work done:
Not done: factor component into its own file
DateFilter.vue had to be duplicated in the template to get it to fit into our mobile designs (it shows in one spot if we are on mobile, a different spot if we aren't).
To prevent duplicating the code, I had wanted to refactor our implementation to put the code in its own component, thus making it easier/shorter to duplicate that component. However, I stopped because the MobileDrawer component needs to pass a removeOverlay method to a specific button on the VueDatePicker to allow it to close the drawer, and I could not figure out how to pass this slot meothd through that many layers without the VueDatePicker button and the MobileDrawer being in the same file.
I'm happy to go back to it if anyone has ideas.
Checklist: