UCLALibrary / ucla-library-website-components

This is a library of Vue components that will be used in UCLA Library Nuxt websites.
Other
6 stars 1 forks source link

fix: APPS-3074 add watchers for pagination reactivity #658

Closed farosFreed closed 5 days ago

farosFreed commented 5 days ago

Connected to APPS-3074

Component Edited: SectionPagination.vue

Stories Updated: ~/stories/SectionPagination.stories.js

Notes:

@pghorpade noticed during implementation in the FTVA project that the SectionPagination.vue component was not mounting correctly.

Upon investigation, this was because we only use the props pages & initialCurrentPage on initialization of the component, not in the render template itself. This PR fixes that.

No visual changes were made

Checklist:

github-actions[bot] commented 5 days ago

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.
github-actions[bot] commented 5 days ago

🚀 Deployed on https://deploy-preview-658--ucla-library-storybook.netlify.app

pghorpade commented 5 days ago

:tada: This PR is included in version 3.35.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: