Per project salt in PIXL hashing - Githubissues

UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory

Apache License 2.0

8 stars 0 forks source link

Per project salt in PIXL hashing #343

Closed stefpiatek closed 4 months ago

stefpiatek commented 5 months ago

Definition of Done / Acceptance Criteria

[ ] PIXL hasher uses the configured project yaml files to have a project-specific salt

Testing

No response

Documentation

No response

Dependencies

Anonymisation library work

Details and Comments

We're now keeping the PIXL-specific hashing API for this iteration so need to make sure that we use a different salt per project in hashing

Suggested flow

[ ] Use project name as the key in azure keyvault, which stores the salt (note: separate Azure Keyvault than the one used for project destination secrets)
[ ] If the key doesn't exist, create it and save it in the keyvault
[ ] in memory cache the salt values (in the hashing api)
[ ] Use this salt in secure hashing

stefpiatek commented 4 months ago

could also have a local env variable for hasher app which is added to the salt each time so that the keyvault alone would not give you the ability to hash identifiers