Closed jeremyestein closed 4 months ago
Explain why unhashed AccNum and PatientID ended up in orthanc-anon(!) Might be due to throwing in the received instance callback. Investigate separately?
I think create a separate issue. Probably worth querying for the pseudonymised study ID in PIXL DB before exporting, then updating the ORM instance with the export date after the export? That way if the pseudonymised ID hasn't been added, it won't be found in the database and an exception will be thrown and it won't be exported
Fix whatever is causing instances in the same study to not end up in the same zip file - The in-test generated dicom data is not mixing well with the static dicom files, so they are not recognised as the same study.
IIRC for system tests we decreased the waiting time for a study to be taken as stable, might be that? Or are they seemingly a different study altogether?
Fixes #346
Apply series filtering in orthanc anon, just before anonymisation. So if series filtering settings change, we can re-run without having to re-download everything to orthanc raw.
TODO
_check_dcm_tags_from_zip
, need to set the expected study/series/instance structure (see_populate_vna
for the source data)Approaches considered but not implemented
Problems with the above: