UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

291 replace dicom anonymization #357

Closed peshence closed 4 months ago

peshence commented 5 months ago

291 Switch from DIY DICOM anonymiasation to Kitware DICOM Anonymizer. In the process:

Possible improvement: Convert current YAMl tag configs to JSON to make use the the existing underlying action loading functionality. We can then do regex replacements and a few other slightly more complex actions. Not sure if it's necessary at this stage.

Possible further actions, which I think shouldn't be in this PR:

milanmlft commented 4 months ago

360 should be good to go and might be useful here as well. Hopefully not too many conflicts 😬

HChughtai commented 4 months ago

Looking into why the whitelisting may be causing an issue with DICOM to Nifti conversion, it does seem like this is due to too aggressive anonymisation removing needed MRI image tags.

It's possible that this is due to required (type 1) attributes in the MR image module being removed. See also https://dicom.innolitics.com/ciods/mr-image/mr-image for a more readable format.

HChughtai commented 4 months ago

Used https://github.com/pydicom/dicom-validator to look at the intermediate anonymised DICOMs, and there were a few things that are being flagged up as missing from a fully valid MR compared to its IOD. The minimum needed to be added are:

peshence commented 4 months ago

Closing in favour of #366