UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

Add unit tests for anonymisation process #360

Closed milanmlft closed 4 months ago

milanmlft commented 4 months ago

Fixes #132

milanmlft commented 4 months ago

The whole private tag class is very odd to me, but that was already in there and everything else looks good. 🚀

What do you think is odd about it? I guess it's just meant as a consistent interface to add custom private tags to DICOM datasets.

peshence commented 4 months ago

Yeah I had some misunderstandings about private tags that @HChughtai helped me out with so it makes a bit more sense now. Thanks both!