UCLH-Foundry / PIXL

PIXL Image eXtraction Laboratory
Apache License 2.0
8 stars 0 forks source link

ehr-api becomes export-api; losing and gaining some features #370

Closed jeremyestein closed 2 months ago

jeremyestein commented 3 months ago

Fixes #321

DICOMWeb uploads are known not to work; this is being fixed in #381

Git hasn't detected some files as renames, so you may wish to do: git difftool main:pixl_ehr/src/pixl_ehr/main.py jeremy/export-api:pixl_export/src/pixl_export/main.py git difftool main:pixl_ehr/tests/test_ehr_processing.py jeremy/export-api:pixl_export/tests/test_export_processing.py etc.

TODO:

milanmlft commented 2 months ago

Will need a few extra tweaks when #379 is merged in, but happy to help out with that!

jeremyestein commented 2 months ago

Will need a few extra tweaks when #379 is merged in, but happy to help out with that!

The merge wasn't too bad and the system test passes for me. Just fixing the core tests, but you can probably start checking that our bits are all joined up.

milanmlft commented 2 months ago

OK so I pushed some changes to update the DICOMweb uploader and its tests, which includes a rework done by @stefpiatek in #378. This will break core and system tests, but that's to be expected because I don't think the DicomWebUploader is working... Sorry about this, #379 shouldn't have been merged in after all 😞